-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
autodiff: emit an error if we fail to find libEnzyme #150060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
7d320f5 to
691c726
Compare
This comment has been minimized.
This comment has been minimized.
691c726 to
f36fcd4
Compare
This comment has been minimized.
This comment has been minimized.
f36fcd4 to
90fe221
Compare
Kobzol
reviewed
Dec 16, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand it correctly get_or_init has a side-effect of loading the Enzyme dylib, so it's fine to call it and just drop the result?
7e1462d to
29cb8fa
Compare
Member
|
You can r=me once CI is green. |
29cb8fa to
793d990
Compare
Member
|
@bors r=Kobzol rollup |
Collaborator
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Dec 17, 2025
autodiff: emit an error if we fail to find libEnzyme Tested manually by moving libEnzyme-21.so away. We should adjust the error msg. once we have the component up. It's the first usage within rustc of this experimental feature, but afaik we're open to dogfooding those for test purpose, right? r? `@Kobzol`
bors
added a commit
that referenced
this pull request
Dec 17, 2025
Rollup of 4 pull requests Successful merges: - #150000 (Port `#[rustc_legacy_const_generics]` to use attribute parser ) - #150060 (autodiff: emit an error if we fail to find libEnzyme) - #150070 (Partially revert #147888 and print warning if LLVM CMake dir is missing when building Enzyme) - #150072 (Port #[no_link] to use attribute parser) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 17, 2025
Rollup merge of #150060 - ZuseZ4:autodiff-dlopen-ice, r=Kobzol autodiff: emit an error if we fail to find libEnzyme Tested manually by moving libEnzyme-21.so away. We should adjust the error msg. once we have the component up. It's the first usage within rustc of this experimental feature, but afaik we're open to dogfooding those for test purpose, right? r? ``@Kobzol``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
F-autodiff
`#![feature(autodiff)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually by moving libEnzyme-21.so away. We should adjust the error msg. once we have the component up.
It's the first usage within rustc of this experimental feature, but afaik we're open to dogfooding those for test purpose, right?
r? @Kobzol